Skip to content

Add name to ignored entries#45051

Merged
balloob merged 2 commits intodevfrom
add-name-to-ignored-entries
Jan 12, 2021
Merged

Add name to ignored entries#45051
balloob merged 2 commits intodevfrom
add-name-to-ignored-entries

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Jan 11, 2021

Breaking change

Proposed change

Fixes #43977

When ignoring a config entry, use the currently shown name for the config entry. That way it can be restored in the future.

I don't want to port the description placeholders because translations can change in the future. So instead we just keep track of what the title was at the moment the user clicked the ignore button.

Left: new, right: old. Name will only be saved on newly ignored entries.

Screenshot 2021-01-11 at 17 16 40@2x

Requires home-assistant/frontend#8135

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob merged commit e83ced6 into dev Jan 12, 2021
@balloob balloob deleted the add-name-to-ignored-entries branch January 12, 2021 08:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show more information in unignore screen

3 participants