Add Tado weather support

[Noltari]

Proposed change

Add weather support for the Tado integration.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
tado:
  username: !secret tado_username
  password: !secret tado_password

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: Add weather support to Tado integration home-assistant.io#16096

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[probot-home-assistant]

Hey there @michaelarnauts, @bdraco, mind taking a look at this pull request as its been labeled with an integration (tado) you are listed as a codeowner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[hencoappel]

Hey,

Left some small comments. Overall looks good though. Looking forward to the change getting in!

[bouwew]

@Noltari I'm sorry, I don't mean to dismiss your work, but why would you want to add this to the Tado integration?
Don't you think that the company behind Tado buys the weather-data from one of the commonly available weather sources, which is probably already covered via one of the existing HA Core weather integrations?

[MatthewFlamm]

I looked this over and it looked good to my eyes. I did notice that you have a humidity method that seems unnecessary, but you are forced by the underlying integration to implement it. I created a PR #45095 to address this.

[Noltari]

@Noltari I'm sorry, I don't mean to dismiss your work, but why would you want to add this to the Tado integration?
Don't you think that the company behind Tado buys the weather-data from one of the commonly available weather sources, which is probably already covered via one of the existing HA Core weather integrations?

@bouwew You're right, but it may be interesting to access Tado weather data, since this is used by Tado to decide if your heating is powered on or not.
BTW, I've compared it with OWM and it doesn't match exactly the data provided by them. There seems to be a slight difference in the temperature and sometimes in the condition too.

[Noltari]

I looked this over and it looked good to my eyes. I did notice that you have a humidity method that seems unnecessary, but you are forced by the underlying integration to implement it. I created a PR #45095 to address this.

@MatthewFlamm Yes, there's no way to get rid of humidity, since it's required by Home Assistant's Weather Entity.

[bouwew]

@Noltari You could add the "values of interest" as sensors that are placed under the Tado hub, or whatever it's called.
This is how we show, for instance, the outdoor temperature in the Plugwise integration:

This sensor can then be shown in the Simple Thermostat Card: https://github.com/nervetattoo/simple-thermostat

[bouwew]

I've just noticed in the mentioned architecture PR that the provided weather data is very limited. Isn't it much simpler and quicker to add 3 sensors instead of adding a full weather implementation?

[Noltari]

@bouwew I added a new commit exporting the weather data as normal sensors.

[elupus]

A quick glance over and most things look okey.

[Noltari]

Ping @michaelarnauts @bdraco

[bdraco]

Given the direction of the arch issue, I'd like to get a second opinion before merging: #44807 (comment)

[Noltari]

@bdraco rebased on latest dev branch (conflict with 198ecb0).

[Noltari]

Hey @MartinHjelmare, would you mind giving a second opinion about this?
Thanks in advance!

[Noltari]

@bdraco @MartinHjelmare rebased on latest dev branch and removed usage of weather constants.

[bdraco]

Will retest shortly

[bdraco]

LGTM