-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce wiz integration for the WiZ Platform #44779
Conversation
Error My run:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like only the coverage check is failing now. There are three untested lines in config_flow.py.
https://github.com/home-assistant/core/pull/44779/checks?check_run_id=1659541458
@esev Thank you for the feedback - I'll try to improve the test coverage. Can I made a dry-run in the devcontainer to check the coverage? |
You're welcome. Hope this helps getting it reviewed faster by one of the core members. Looks like everything is green now. Nice work on this integration.
I've been using the last example: In case you want to check the code coverage for your new component |
I have been running the sbidy/wiz_light integration for a while and thought I would take this PR for a spin. A couple of observations/thoughts: Missing label/explanation for host address inputInput validation error messageIf triggering an input validation error with a non-supported address, the Name field will reset. Limited to adding lights by IP through GUIMy router runs OpenWRT and will happily register and resolve DHCP client hostnames. This means that I don't have to worry about static DHCP address entries, and have defined my lights in the following manner from previously: light:
- platform: wiz_light
name: spisebord
host: wiz_7395e0 Should it work the same way through the GUI as through configuration.yaml? Thumbs upThumbs up and thank you @sbidy for moving this forward 😄 |
I added some enhancements to the integration. Now it is possible to use hostnames and ips to add bulbs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Looks like some cosmetic changes left, otherwise ok to merge
Tested it, works fine! |
Co-authored-by: Franck Nijhof <[email protected]>
Co-authored-by: Franck Nijhof <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments in a new PR. Thanks!
Woow - insane things happen here :) !!! Thank you !!! |
Hype! Thanks for all the work everyone! Will be using this a lot in my home. |
This should be the last cleanup on the HASS side from me. I'm going to take a look and see what we can do to make the lib less chatty when the bulb is offline |
I merged the PR on the lib side. I'll test it and create a new release for that. |
Proposed change
A HA integration for WiZ Platform - mainly for bulbs (Phillips, SLV and more). The integration extents HA to communicate directly with this WiFi connected WiZ devices via async UDP calls. There is no Cloud or Web API needed for interaction with this lights.
The integration is designed async, including the UDP calls via pywizlight extension.
Supported Features (Bulbs):
Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: