Add config flow support to google_travel_time by raman325 · Pull Request #43509 · home-assistant/core

raman325 · 2020-11-22T06:59:51Z

Breaking Change

Config flow support has been added to google_travel_time. Existing YAML configuration entries will be imported automatically but should be removed from YAML configuration after import. Import support will be removed in a future release.

Proposed change

Added config flow support to google_travel_time. Platform setup was retained via config flow import to ease the transition.

Follow up tasks (in separate PRs):

Remove import option after several releases
Move options to options flow (they are currently part of the regular config flow to minimize code changes)

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

Link to documentation pull request: Update google_travel_time docs to reflect config flow support home-assistant.io#15716

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

No score or internal
🥈 Silver
🥇 Gold
🏆 Platinum

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

ctalkington · 2020-12-02T05:22:16Z

this will need a breaking change notice, even though it technically isn't breaking, as its used when creating release blog post.

raman325 · 2020-12-05T15:57:35Z

this will need a breaking change notice, even though it technically isn't breaking, as its used when creating release blog post.

Same question/answer posted here: #43419 (comment)

github-actions · 2021-01-26T21:17:58Z

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

raman325 · 2021-01-26T21:26:59Z

still valid

github-actions · 2021-02-26T16:29:03Z

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

raman325 · 2021-02-26T16:36:03Z

still valid

github-actions · 2021-03-28T18:15:33Z

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

raman325 · 2021-03-28T19:41:32Z

still valid

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

…-assistant into google_config_flow * 'google_config_flow' of https://github.com/raman325/home-assistant: Update homeassistant/components/google_travel_time/sensor.py

MartinHjelmare

Great!

homeassistant added the cla-signed label Nov 22, 2020

probot-home-assistant Bot added has-tests integration: google_travel_time new-feature labels Nov 22, 2020

raman325 mentioned this pull request Nov 22, 2020

Update google_travel_time docs to reflect config flow support home-assistant/home-assistant.io#15716

Merged

8 tasks

dennisschroer reviewed Nov 22, 2020

View reviewed changes

Comment thread homeassistant/components/google_travel_time/config_flow.py Outdated

Comment thread homeassistant/components/google_travel_time/translations/en.json

raman325 force-pushed the google_config_flow branch from 626df7a to 68ab995 Compare November 24, 2020 06:17

ctalkington reviewed Dec 2, 2020

View reviewed changes

Comment thread homeassistant/components/google_travel_time/sensor.py Outdated

ctalkington reviewed Dec 2, 2020

View reviewed changes

Comment thread homeassistant/components/google_travel_time/strings.json

raman325 added the breaking-change label Dec 6, 2020

github-actions Bot added the stale label Jan 26, 2021

raman325 force-pushed the google_config_flow branch from af83862 to 864ef10 Compare January 26, 2021 21:26

github-actions Bot removed the stale label Jan 26, 2021

raman325 added 7 commits January 27, 2021 11:10

add config flow support to google_travel_time

cfbae18

fix bugs and add strings

d3be6e6

fix import and add new test

a9ba9d4

address comments in home-assistant#43419 since this is a similar PR

a1a0620

fix default name and test

e9027e3

add unique ID and device info

8344784

fix test

a796cf1

raman325 force-pushed the google_config_flow branch from 7fc79dd to a796cf1 Compare January 27, 2021 16:10

github-actions Bot added the stale label Feb 26, 2021

github-actions Bot removed the stale label Feb 26, 2021

github-actions Bot added the stale label Mar 28, 2021

Merge branch 'dev' into google_config_flow

d1869f8

github-actions Bot removed the stale label Mar 28, 2021

raman325 added 3 commits March 29, 2021 12:37

feedback from waze PR

477a976

continue incorporating feedback from waze PR

458bb2f

final fixes and update tests

fea4193

MartinHjelmare requested changes Mar 30, 2021

View reviewed changes

raman325 and others added 4 commits March 30, 2021 08:27

call update in lambda

61693cc

Update homeassistant/components/google_travel_time/sensor.py

e608d24

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

Merge branch 'google_config_flow' of https://github.com/raman325/home…

567a718

…-assistant into google_config_flow * 'google_config_flow' of https://github.com/raman325/home-assistant: Update homeassistant/components/google_travel_time/sensor.py

additional fixes

c69f4ef

MartinHjelmare reviewed Mar 30, 2021

View reviewed changes

Comment thread homeassistant/components/google_travel_time/sensor.py Outdated

Comment thread homeassistant/components/google_travel_time/sensor.py Outdated

raman325 added 5 commits March 30, 2021 09:59

validate config entry data during config flow and config entry setup

90e9a29

don't store entity

b1a8a80

patch dependency instead of HA code

82c5354

fixes

407f986

improve tests by moving all patching to fixtures

dbf417d

MartinHjelmare reviewed Mar 31, 2021

View reviewed changes

Comment thread homeassistant/components/google_travel_time/sensor.py Outdated

raman325 added 3 commits March 31, 2021 10:39

use self.hass instead of setting self._hass

fe551d8

invert if

dda4a97

remove unnecessary else

84ffa14

MartinHjelmare approved these changes Mar 31, 2021

View reviewed changes

MartinHjelmare merged commit aae0ccc into home-assistant:dev Mar 31, 2021

raman325 deleted the google_config_flow branch March 31, 2021 20:12

github-actions Bot locked and limited conversation to collaborators Apr 1, 2021

Uh oh!

Conversation

raman325 commented Nov 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking Change

Proposed change

Type of change

Additional information

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ctalkington commented Dec 2, 2020

Uh oh!

raman325 commented Dec 5, 2020

Uh oh!

github-actions Bot commented Jan 26, 2021

Uh oh!

raman325 commented Jan 26, 2021

Uh oh!

github-actions Bot commented Feb 26, 2021

Uh oh!

raman325 commented Feb 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 28, 2021

Uh oh!

raman325 commented Mar 28, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

raman325 commented Nov 22, 2020 •

edited

Loading

raman325 commented Feb 26, 2021 •

edited

Loading