Skip to content

Deprecate YAML config for Solar-log#43484

Merged
frenck merged 1 commit intohome-assistant:devfrom
Ernst79:solarlog_remove_configuration
Nov 21, 2020
Merged

Deprecate YAML config for Solar-log#43484
frenck merged 1 commit intohome-assistant:devfrom
Ernst79:solarlog_remove_configuration

Conversation

@Ernst79
Copy link
Copy Markdown
Contributor

@Ernst79 Ernst79 commented Nov 21, 2020

Breaking change

Per ADR-0010, this PR deprecates YAML configuration for the Solar-log integration. Users who already use the Solar-log integration do not need to take action, as their configuration has already been imported into the UI.

Proposed change

Per ADR-0010, this PR deprecates YAML configuration for the Solar-log integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Deprecated

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: #15713

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Per ADR-0010, this PR deprecates YAML configuration for Solar-log. Users who already use the Solar-log integration do not need to take action, as their configuration has already been imported into the UI.
Comment thread homeassistant/components/solarlog/sensor.py
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks 👍

@frenck frenck merged commit 977ed94 into home-assistant:dev Nov 21, 2020
@Ernst79 Ernst79 deleted the solarlog_remove_configuration branch November 21, 2020 17:18
Comment thread homeassistant/components/solarlog/sensor.py
Comment thread homeassistant/components/solarlog/sensor.py
@frenck frenck mentioned this pull request Nov 21, 2020
21 tasks
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants