Skip to content

Bump env_canada to 0.2.4, fix config validation#43251

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
michaeldavie:env_canada_0-2-4
Nov 16, 2020
Merged

Bump env_canada to 0.2.4, fix config validation#43251
MartinHjelmare merged 2 commits intohome-assistant:devfrom
michaeldavie:env_canada_0-2-4

Conversation

@michaeldavie
Copy link
Copy Markdown
Contributor

@michaeldavie michaeldavie commented Nov 15, 2020

Proposed change

  • Bumps version of env_canada
  • Fixes validation of the precip_type configuration parameter for the camera component

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
weather:
  - platform: environment_canada

camera:
  - platform: environment_canada
    precip_type: RAIN

sensor:
  - platform: environment_canada

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@ctalkington ctalkington changed the title Bump env_canada, remove C dependency Bump env_canada to 0.2.4 (remove C dependency) Nov 15, 2020
@michaeldavie michaeldavie changed the title Bump env_canada to 0.2.4 (remove C dependency) Bump env_canada to 0.2.4, fix config validation Nov 15, 2020
@exxamalte
Copy link
Copy Markdown
Contributor

LGTM.
Normally, I think it is preferred to keep library updates separate from bugfixes, just to avoid any confusion in the case where one may impact the other. In this particular case it's probably OK to have both in one PR.

And, as a side note (not for this PR), can I please encourage you to add unit tests to this integration as well as to your third-party library? That may have detected some of the issues you are fixing now. Thanks.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 0.118.0 milestone Nov 16, 2020
@MartinHjelmare MartinHjelmare merged commit 4ffba28 into home-assistant:dev Nov 16, 2020
@michaeldavie
Copy link
Copy Markdown
Contributor Author

And, as a side note (not for this PR), can I please encourage you to add unit tests to this integration as well as to your third-party library? That may have detected some of the issues you are fixing now. Thanks.

Thanks @exxamalte, this is a good point. I've started adding tests to the library, and I'll work on adding them to the integration as well.

@michaeldavie michaeldavie deleted the env_canada_0-2-4 branch November 17, 2020 04:10
KJonline pushed a commit to Pyhass/core that referenced this pull request Nov 17, 2020
* 'dev' of https://github.com/home-assistant/core: (77 commits)
  Fix kodi media_player unavailable at start (home-assistant#41714)
  Add an option to template delay_on/off in template binary sensor (home-assistant#43259)
  Bump hatasmota to 0.0.31 (home-assistant#43319)
  Update cloud integration to 0.38.0 (home-assistant#43314)
  Add progress translation key to hassfest (home-assistant#43311)
  Bump codecov/codecov-action from v1.0.14 to v1.0.15 (home-assistant#43304)
  Improvement to allow parsing of station ID in vasttrafik integration. Addresses home-assistant#34851 (home-assistant#43136)
  Abort vizio discovery flow without unique ID (home-assistant#43303)
  Update directv to 0.4.0 (home-assistant#43302)
  Add notification binary_sensor to Plugwise integration (home-assistant#41473)
  [ci skip] Translation update
  Bump bimmer_connected to 0.7.13 (home-assistant#43294)
  Bump aioguardian to 1.0.4 (home-assistant#43299)
  Refactor how entities are created for homekit_controller services (home-assistant#43242)
  Updated frontend to 20201111.1 (home-assistant#43298)
  Update pytradfri to 7.0.4 (home-assistant#43297)
  Remove pts adjustments in stream (home-assistant#42399)
  Fix Enigma2 available entity property (home-assistant#43292)
  Make MQTT climate return PRESET_NONE when no preset is set (home-assistant#43257)
  Bump env_canada to 0.2.4, fix config validation (home-assistant#43251)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants