Skip to content

Streamline SimpliSafe errors #43117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Nov 13, 2020
Merged

Streamline SimpliSafe errors #43117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6291046
Streamline SimpliSafe errors
bachya Nov 11, 2020
65817e9
Linting
bachya Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions homeassistant/components/simplisafe/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,8 +534,7 @@ async def async_update_system(system):
)
)

LOGGER.error("Update failed with stored refresh token")
raise UpdateFailed from result
raise UpdateFailed("Update failed with stored refresh token")

LOGGER.warning("SimpliSafe cloud error; trying stored refresh token")
self._emergency_refresh_token_used = True
Expand All @@ -546,23 +545,18 @@ async def async_update_system(system):
)
return
except SimplipyError as err:
LOGGER.error("Error while using stored refresh token: %s", err)
raise UpdateFailed from err
raise UpdateFailed( # pylint: disable=raise-missing-from
f"Error while using stored refresh token: {err}"
)

if isinstance(result, EndpointUnavailable):
# In case the user attempt an action not allowed in their current plan,
# In case the user attempts an action not allowed in their current plan,
# we merely log that message at INFO level (so the user is aware,
# but not spammed with ERROR messages that they cannot change):
LOGGER.info(result)
raise UpdateFailed from result

if isinstance(result, SimplipyError):
LOGGER.error("SimpliSafe error while updating: %s", result)
raise UpdateFailed from result

if isinstance(result, Exception):
LOGGER.error("Unknown error while updating: %s", result)
raise UpdateFailed from result
raise UpdateFailed(f"SimpliSafe error while updating: {result}")

if self._api.refresh_token != self.config_entry.data[CONF_TOKEN]:
_async_save_refresh_token(
Expand Down