Skip to content

Fix incorrect Notion battery state calculation #43108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bachya merged 2 commits into from
Nov 12, 2020
Merged

Fix incorrect Notion battery state calculation #43108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00cc17f
Fix incorrect Notion battery state calculation
bachya Nov 11, 2020
8584e91
Both cases
bachya Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions homeassistant/components/notion/binary_sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,22 +79,18 @@ def _async_update_from_latest_data(self) -> None:
"""Fetch new state data for the sensor."""
task = self.coordinator.data["tasks"][self._task_id]

if task["task_type"] == SENSOR_BATTERY:
self._state = self.coordinator.data["tasks"][self._task_id]["status"][
"data"
]["to_state"]
else:
self._state = self.coordinator.data["tasks"][self._task_id]["status"][
"value"
]
if "value" in task["status"]:
self._state = task["status"]["value"]
elif task["task_type"] == SENSOR_BATTERY:
self._state = task["status"]["data"]["to_state"]

@property
def is_on(self) -> bool:
"""Return whether the sensor is on or off."""
task = self.coordinator.data["tasks"][self._task_id]

if task["task_type"] == SENSOR_BATTERY:
return self._state != "critical"
return self._state == "critical"
if task["task_type"] in (
SENSOR_DOOR,
SENSOR_GARAGE_DOOR,
Expand Down