Initial camera support for homekit_controller#43100
Merged
Jc2k merged 1 commit intohome-assistant:devfrom Nov 14, 2020
Merged
Conversation
cmroche
reviewed
Nov 14, 2020
| "documentation": "https://www.home-assistant.io/integrations/homekit_controller", | ||
| "requirements": [ | ||
| "aiohomekit==0.2.54" | ||
| "aiohomekit==0.2.57" |
Contributor
There was a problem hiding this comment.
Don't forget to mark the dependency upgrade in the MR template.
Member
Author
There was a problem hiding this comment.
Of course happy to do this, but the PR template says to only check 1 box.
cmroche
approved these changes
Nov 14, 2020
Member
Author
|
Cheers for the review! |
This was referenced Nov 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add initial support for homekit cameras like eufycam 2c or Eve Cam.
This is the bare minimum to discover the camera and support still images - at the moment we don't negotiate any full video streams.
Getting the current streaming/not streaming state will require some refactoring which i'll do in a seperate PR.
Tested with 3 eufycam 2c.
Type of change
Example entry for
configuration.yaml:N/A
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: