Change Plugwise integration to plugwise module#43036
Merged
ctalkington merged 8 commits intohome-assistant:devfrom Nov 21, 2020
Merged
Change Plugwise integration to plugwise module#43036ctalkington merged 8 commits intohome-assistant:devfrom
ctalkington merged 8 commits intohome-assistant:devfrom
Conversation
bouwew
reviewed
Nov 10, 2020
Contributor
bouwew
left a comment
There was a problem hiding this comment.
One small improvement possible.
bouwew
approved these changes
Nov 10, 2020
Contributor
bouwew
left a comment
There was a problem hiding this comment.
Looking good now after the changes.
16 tasks
Member
Author
Only added tests to pass patch coverage - waiting for open PR to 'ready for review' |
ca183ab to
d0d1512
Compare
ctalkington
reviewed
Nov 18, 2020
|
Thank you so much
On Wed, 18 Nov 2020 at 4:29 PM, Tom ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/components/plugwise/test_switch.py
<#43036 (comment)>:
> + entry = await async_init_integration(hass, mock_smile_adam)
+ assert entry.state == ENTRY_STATE_LOADED
+
+ await hass.services.async_call(
+ "switch",
+ "turn_off",
+ {"entity_id": "switch.cv_pomp"},
+ blocking=True,
+ )
+ state = hass.states.get("switch.cv_pomp")
+ assert str(state.state) == "on"
+
+ await hass.services.async_call(
+ "switch",
+ "turn_on",
+ {"entity_id": "switch.fibaro_hc2"},
link/loc of fixture source
<https://github.com/plugwise/python-plugwise/blob/6e340ce4957cc3415658ddf4ccb7c34046ad7090/userdata/adam_multiple_devices_per_zone/core.domain_objects.xml#L3255>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#43036 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARUZXJV5DBT6ELBYY4PJ4DDSQNPELANCNFSM4TQNFHDA>
.
--
Mail from Gmail
|
ctalkington
reviewed
Nov 21, 2020
| blocking=True, | ||
| ) | ||
| state = hass.states.get("climate.zone_thermostat_jessie") | ||
| attrs = state.attributes |
Contributor
There was a problem hiding this comment.
was it intended to assert something here?
Contributor
There was a problem hiding this comment.
ill go ahead and approve this, just double check this test in your usb branch or next PR.
Member
Author
There was a problem hiding this comment.
@ctalkington will do in the usb-branch coming up
ctalkington
approved these changes
Nov 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Final changes before we can draft the successor of #35713 - Some background to this PR. As requested in #35713 we joined forces but as a team decided to not only merge the HA-code but also our module! As such this PR swaps
Plugwise_Smileforplugwise. To keep changes to a minimum this PR only adjusts the current integration for usage of the new module.For reviewers, to clarify why we use
async_setup_entryas a wrapper inswitch.pywill default to the current workings unlessPW_TYPEis set to USB. (Hence the placeholder stub).Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: