Skip to content

Deprecate YAML config for Notion (0.119 removal)#43026

Merged
ctalkington merged 1 commit into
home-assistant:devfrom
bachya:notion-yaml
Nov 10, 2020
Merged

Deprecate YAML config for Notion (0.119 removal)#43026
ctalkington merged 1 commit into
home-assistant:devfrom
bachya:notion-yaml

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Nov 10, 2020

Breaking change

Per ADR-0010, this PR deprecates YAML configuration for Notion until 0.119. Users who already use the Notion integration do not need to take action, as their configuration has already been imported into the UI.

Proposed change

Per ADR-0010, this PR deprecates YAML configuration for Notion until 0.119.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@ctalkington ctalkington merged commit 244bfb2 into home-assistant:dev Nov 10, 2020
@bachya bachya deleted the notion-yaml branch November 10, 2020 19:33
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants