Skip to content

Bump pyvlx to 0.2.18#42895

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
sbyx:bump-pyvlx-0.2.18
Nov 6, 2020
Merged

Bump pyvlx to 0.2.18#42895
MartinHjelmare merged 1 commit intohome-assistant:devfrom
sbyx:bump-pyvlx-0.2.18

Conversation

@sbyx
Copy link
Contributor

@sbyx sbyx commented Nov 6, 2020

Proposed change

This updates pyvlx library used by velux integration to 0.2.18 fixing issue with timeouts when connecting to the Velux KLF-200.

pyvlx was supposedly updated to 0.2.17 with #40182 however the 0.2.17 version available using pip was actually not the intended 0.2.17 release of pyvlx as indicated here: Julius2342/pyvlx#54
The author has therefore released 0.2.18 which addresses this.

https://github.com/Julius2342/pyvlx/releases/tag/0.2.18

Julius2342/pyvlx@0.2.17...0.2.18

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following [Integration Quality Scale][quality-scale]:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Julius2342, mind taking a look at this pull request as its been labeled with an integration (velux) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@epenet epenet mentioned this pull request Nov 6, 2020
21 tasks
@epenet
Copy link
Contributor

epenet commented Nov 6, 2020

Ref #42773

@MartinHjelmare MartinHjelmare changed the title velux: bump pyvlx to 0.2.18 Bump pyvlx to 0.2.18 Nov 6, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I've added links to the release and compare range for the version bump in the PR description.

@MartinHjelmare MartinHjelmare merged commit 1e87ac7 into home-assistant:dev Nov 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants