Skip to content

Add complex light support to HomeKit#42807

Closed
AlexOwl wants to merge 8 commits intohome-assistant:devfrom
AlexOwl:homekit-complex-light
Closed

Add complex light support to HomeKit#42807
AlexOwl wants to merge 8 commits intohome-assistant:devfrom
AlexOwl:homekit-complex-light

Conversation

@AlexOwl
Copy link
Copy Markdown

@AlexOwl AlexOwl commented Nov 3, 2020

Proposed change

The ability to use both temperature and hue characteristics by HomeKit light accessory

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • [+] New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

homekit:
  - ...
     entity_config:
       light.temperature_and_hue:
         complex_light: True

Additional information

Currently it is impossible to use bulbs that support temperature and color modes, since they work only in color mode in homekit (it was decided to make because of "source of truth" problem. However, a lot of users and I want to use have ability to change temperature from homekit - this PR adds config option "complex_light" for advanced users

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Allow Light accessory to have both temperature and hue characteristic
CONF_COMPLEX_LIGHT is used to allow light accessory to use both temperature and hue characteristics
Add light scheme to be able to use CONF_COMPLEX_LIGHT option
@probot-home-assistant probot-home-assistant bot added integration: homekit small-pr PRs with less than 30 lines. labels Nov 3, 2020
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @AlexOwl,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Nov 4, 2020

The HomeKit R2 spec explicitly states that the Color Temperature char must not be used for lamps which support color.

@bdraco bdraco closed this Nov 23, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants