Remove YAML config for synology_dsm

[Quentame]

Breaking change

Synology DSM has fully transitioned to configuration via UI. YAML configuration is no longer supported after being automatically imported for several releases.

Proposed change

Following ADR-0010: https://github.com/home-assistant/architecture/blob/master/adr/0010-integration-configuration.md

In draft because CONF_DISKS and CONF_VOLUMES need some love to be configured.
It was only possible to set them at import, so we should either:

• remove them from the configuration (and disabled entries afterwards if wanted)
• add a config in the options flow --> is a multi select available in the UI ?

What should I do ?

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Answer to #42539 (comment)

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[bdraco]

cv.multi_select works in config flows. homekit has an example.

[mib1185]

Hi @Quentame ,
I would like to contribute to this PR, but do not know how I can push to your hacf-fr:synology_dsm/remove_yaml or if there is another way to do so?

[Quentame]

Hi !
I will give you rights on it tonight.

[Quentame]

Added you to the repo.
You should now have access to it, with push rights.

TODO:

• add disks and volumes to options config
• use cv.multi_select to add select needed device (prefill with all)
• if no change or full select, store nothing/None

While writing this, I am thinking that it would be easier to remove this config, and I think we should remove it.
This is why:

• I don't think this is used anymore
• Before config entry, fetching might be multiple per device, but not now
• Before config entry, we couldn't remove/disable an entry via the UI, but not now
• How should we handle when the user add a new device (disk or volume)? Add the new device automatically or wait for the user to add it ?
• Same question when a device is removed (and will generate errors)
• Removing this config will make the integration easier to maintain and avoid dev work.

What do you think @mib1185 ?

[mib1185]

Hi @Quentame ,

I have already pushed a commit, where I added an additional setup step to define, if user wants to limit/filter the disks and volumes to add, or not 😉
To address these two points:

• How should we handle when the user add a new device (disk or volume)? Add the new device automatically or wait for the user to add it ?
• Same question when a device is removed (and will generate errors)

I would suggest to implement something like "reconfigure is needed" as I already have seen on another integration 🤔

[Quentame]

Devices should never be undefined
--> self.syno_info[CONF_...]

[mib1185]

In case of an virtual DSM running on virtual machine manager, there are no disks available (see #42523), but yes for volumes - they never should be undefined ... I will change it

[Quentame]

Yep, good work 👏🏼, but is this (future) work worth it ?

We should not code this for the fun of doing it but for the good of the integration.
I prefer to focus on fixing issues or adding new features to the end user. So that it will be use everyday and not only at config.

[mib1185]

Yeah, I fully agree with you, that we should not code for the fun of doing it but for the good of the integration and we should focus on fixing issues or adding new features to the end user. 👍
But in this case, the work is nearly done and most of the logic to consider, if disks/volumes has been selected or not, is already in place from previous yaml configuration approach - examples:

core/homeassistant/components/synology_dsm/sensor.py

Line 45 in 149ba08

for volume in entry.data.get(CONF_VOLUMES, api.storage.volumes_ids):

core/homeassistant/components/synology_dsm/binary_sensor.py

Line 42 in 149ba08

for disk in entry.data.get(CONF_DISKS, api.storage.disks_ids):

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

[frenck]

This PR has been in a draft and running stale without activity since November.
I'll go ahead and close this PR for now. Feel free to re-open the PR again when ready to start working on it. Contributions are always appreciated 👍