Skip to content

Small cleanup to IQVIA DataUpdateCoordinator logic#42642

Merged
ctalkington merged 1 commit intohome-assistant:devfrom
bachya:iqvia-cleanup
Oct 30, 2020
Merged

Small cleanup to IQVIA DataUpdateCoordinator logic#42642
ctalkington merged 1 commit intohome-assistant:devfrom
bachya:iqvia-cleanup

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Oct 30, 2020

Proposed change

This PR makes two small updates to IQVIA's DataUpdateCoordinator logic:

  1. Use a partial instead of a lambda when creating the coordinators update methods.
  2. Don't repeat logic already implemented by CoordinatorEntity.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@ctalkington ctalkington merged commit 036a8b5 into home-assistant:dev Oct 30, 2020
@bachya bachya deleted the iqvia-cleanup branch November 6, 2020 19:18
Thomas55555 pushed a commit to Thomas55555/core that referenced this pull request Feb 24, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants