Skip to content

Bump hatasmota to 0.0.26#42613

Merged
emontnemery merged 4 commits intohome-assistant:devfrom
effelle:new_status_sensors
Oct 30, 2020
Merged

Bump hatasmota to 0.0.26#42613
emontnemery merged 4 commits intohome-assistant:devfrom
effelle:new_status_sensors

Conversation

@effelle
Copy link
Copy Markdown
Contributor

@effelle effelle commented Oct 29, 2020

Proposed change

Bump hatasmota from 0.0.25 to 0.0.26 which adds some new status sensors.
Also make sure all status sensors are added as hidden entities.

Changes:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @emontnemery, mind taking a look at this pull request as its been labeled with an integration (tasmota) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Comment thread homeassistant/components/tasmota/sensor.py Outdated
@effelle effelle requested a review from emontnemery October 30, 2020 13:08
@emontnemery emontnemery merged commit 2dc5c4d into home-assistant:dev Oct 30, 2020
@emontnemery emontnemery added this to the 0.117.2 milestone Oct 30, 2020
@MartinHjelmare
Copy link
Copy Markdown
Member

Why is this part of the patch milestone?

@emontnemery
Copy link
Copy Markdown
Contributor

emontnemery commented Oct 30, 2020

@MartinHjelmare I added it to the patch milestone to make sure all status sensors are added as hidden entities. It's a bit of a mixed bag though since 0.0.26 also adds some new status sensors.

@MartinHjelmare
Copy link
Copy Markdown
Member

That's a new feature and we don't allow those in patch releases.

@emontnemery emontnemery removed this from the 0.117.2 milestone Oct 30, 2020
@emontnemery
Copy link
Copy Markdown
Contributor

OK, removed from milestone.
Is it possible to open a PR targetting only the patch release, or should we revert this one and split in two: one to bump hatasmota and one to fix hiding of sensors?

@MartinHjelmare
Copy link
Copy Markdown
Member

Both are possible. If we target the rc branch directly the PR should be labeled with cherry picked label to avoid getting cherry picked again, I think. Please coordinate with the person doing the patch release in this case.

emontnemery added a commit that referenced this pull request Oct 30, 2020
emontnemery added a commit that referenced this pull request Oct 30, 2020
@emontnemery
Copy link
Copy Markdown
Contributor

OK, replaced by #42643 + #42644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed dependency Pull requests marked as a dependency upgrade Hacktoberfest integration: tasmota new-feature small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants