Skip to content

Fix inexact version of pylacrosse#42610

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
onkelbeh:patch-1
Oct 29, 2020
Merged

Fix inexact version of pylacrosse#42610
MartinHjelmare merged 2 commits intohome-assistant:devfrom
onkelbeh:patch-1

Conversation

@onkelbeh
Copy link
Copy Markdown
Contributor

@onkelbeh onkelbeh commented Oct 29, 2020

Proposed change

In home-assistant-core/homeassistant/components/lacrosse/manifest.json pylacrosse is pinned to version 0.4.0 which is not listed.

Please see:

Even if Home Assistant's current dependency manager tolerates this inaccuracy, this could be corrected.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant Bot added bugfix integration: lacrosse small-pr PRs with less than 30 lines. dependency-bump Pull requests that update a dependency file labels Oct 29, 2020
@MartinHjelmare MartinHjelmare changed the title fix inexact version of pylacrosse ffix inexact version of pylacrosse Oct 29, 2020
@MartinHjelmare MartinHjelmare changed the title ffix inexact version of pylacrosse Fix inexact version of pylacrosse Oct 29, 2020
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit c403534 into home-assistant:dev Oct 29, 2020
@onkelbeh
Copy link
Copy Markdown
Contributor Author

onkelbeh commented Oct 30, 2020

You are very welcome.

Thomas55555 pushed a commit to Thomas55555/core that referenced this pull request Feb 24, 2026
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix cla-signed dependency-bump Pull requests that update a dependency file Hacktoberfest integration: lacrosse small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants