Skip to content

Fix broken time trigger test#42606

Merged
balloob merged 3 commits intodevfrom
maybe-fix-trigger-time
Oct 29, 2020
Merged

Fix broken time trigger test#42606
balloob merged 3 commits intodevfrom
maybe-fix-trigger-time

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Oct 29, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration (homeassistant) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob force-pushed the maybe-fix-trigger-time branch from 78d101d to a0f0df2 Compare October 29, 2020 20:35
@balloob balloob changed the title Maybe fix broken time trigger test Fix broken time trigger test Oct 29, 2020
@balloob balloob merged commit 7027b01 into dev Oct 29, 2020
@balloob balloob deleted the maybe-fix-trigger-time branch October 29, 2020 21:34
assert hass.config.external_url == "https://www.example.com"
assert hass.config.internal_url == "http://example.local"

dt_util.set_default_time_zone(ORIG_TIME_ZONE)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this makes the global definition of ORIG_TIME_ZONE redundant.

@balloob balloob added this to the 0.117.2 milestone Oct 30, 2020
balloob added a commit that referenced this pull request Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants