Fix MQTT template light#42598
Merged
springstan merged 1 commit intohome-assistant:devfrom Oct 29, 2020
Merged
Conversation
probot-home-assistant
Bot
added
Hacktoberfest
bugfix
core
integration: mqtt
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration ( |
springstan
approved these changes
Oct 29, 2020
| _LOGGER.warning("Invalid color value received") | ||
|
|
||
| if self._templates[CONF_COLOR_TEMP_TEMPLATE] is not None: | ||
| if self._templates[CONF_WHITE_VALUE_TEMPLATE] is not None: |
Member
There was a problem hiding this comment.
Is there no test for this?
Contributor
Author
There was a problem hiding this comment.
Yes there is a test, but the problem is that the test case has both the white_value_template and a color_temp_template set so this copy-paste-error was not found.
Maybe the test could be rewritten to be parametrized, and loop over a list of templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix broken handling of white value template in MQTT template light
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: