Skip to content

Deprecate YAML config for AirVisual (0.119 removal)#42581

Merged
frenck merged 2 commits intohome-assistant:devfrom
bachya:airvisual-yaml
Nov 9, 2020
Merged

Deprecate YAML config for AirVisual (0.119 removal)#42581
frenck merged 2 commits intohome-assistant:devfrom
bachya:airvisual-yaml

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Oct 29, 2020

Breaking change

Per ADR-0010, this PR deprecates YAML configuration for AirVisual until 0.119. Users who already use the AirVisual integration do not need to take action, as their configuration has already been imported into the UI.

Proposed change

Per ADR-0010, this PR deprecates YAML configuration for AirVisual until 0.119.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: TBD

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bachya 👍

@frenck frenck merged commit 3707b72 into home-assistant:dev Nov 9, 2020
@bachya bachya deleted the airvisual-yaml branch November 9, 2020 17:54
@GeorgeSG
Copy link
Copy Markdown
Contributor

GeorgeSG commented Dec 2, 2020

That's pretty cool, but now there is no way to setup AirVisualGeographySensors because there's no support for them in Config Flow.
Edit: by AirVusalGeographySensor I mean a sensor set up from country/state/city.

Are they being deprecated (and the only option will be lat/lng going forward), or is this just missing in the UI and needs to be added?

@bachya
Copy link
Copy Markdown
Contributor Author

bachya commented Dec 2, 2020

@GeorgeSG The UI configuration allows for the setup of geography sensors via latitude/longitude – is there a use case where country/state/city is more effective than latitude/longitude?

@GeorgeSG
Copy link
Copy Markdown
Contributor

GeorgeSG commented Dec 2, 2020

@bachya I'm new to this integration, but I think there is a use case, yes.

Whatever I try, I cannot add a sensor for this location: https://www.iqair.com/bulgaria/sofia/sofia-mladost. Any lat/long I choose defaults to https://www.iqair.com/bulgaria/sofia.

There are multiple stations in Sofia, and I can only setup a sensor for what seems to be the default one:

image

I am hoping being able to specify country/state/city will solve this problem.

@bachya
Copy link
Copy Markdown
Contributor Author

bachya commented Dec 2, 2020

@GeorgeSG Got it. And you can confirm that with the previous country/state/city YAML configuration, you could get the station you want?

@GeorgeSG
Copy link
Copy Markdown
Contributor

GeorgeSG commented Dec 2, 2020

@bachya I haven't used the integration before, will yaml config work with this version?

@bachya
Copy link
Copy Markdown
Contributor Author

bachya commented Dec 3, 2020

@GeorgeSG No, that has been removed as part of this PR – sorry, from your previous comments, I had assumed you had previously used this integration.

@PhilRW
Copy link
Copy Markdown
Contributor

PhilRW commented Dec 9, 2020

@bachya I have the use case. I tried setting up my location via lat/lon but it did not report correctly - kept giving me NOx readings instead of PM2.5. Using the YAML I configured the location by country/city/state and it's worked appropriately ever since. Something with their API, I guess. Anyway, I would appreciate a way to configure it via location name before the YAML is deprecated.

@bachya
Copy link
Copy Markdown
Contributor Author

bachya commented Dec 9, 2020

Thanks, @PhilRW – appreciate the info. I'm on it.

@bachya
Copy link
Copy Markdown
Contributor Author

bachya commented Feb 1, 2021

@GeorgeSG @PhilRW FYI, #44116 has added this. Too late for 2021.2.0, I'm afraid, so it will land in the March release. A reminder that if you don't want to wait until then, you can always download that PR as a custom component.

Thomas55555 pushed a commit to Thomas55555/core that referenced this pull request Feb 24, 2026
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants