Use list literal without using dict.keys()

[springstan]

Breaking change

Proposed change

Just some more clean up, removing using dict.keys() inside of a list literal.

Example:

# Before:
list(my_dict.keys())

# After:
list(my_dict)

Doing this because it is faster and IMO easier to read as well.

import timeit

old_thing = """
mydict = {}
for x in range(500):
    mydict[str(x)] = x

keys = list(mydict.keys())
"""

new_thing = """
mydict = {}
for x in range(500):
    mydict[str(x)] = x

mylist = list(mydict)
"""

print("old: ", timeit.timeit(stmt=old_thing))
print("new: ", timeit.timeit(stmt=new_thing))

Output:

old:  130.94198324799981
new:  130.59963818100005

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
n/a

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[MartinHjelmare]

Side note for a future clean up: It's better to define a reverse dict constant at the module level and look up. This is inefficient.

[springstan]

Not sure if I have caused this test failure:
FAILED tests/components/homekit/test_config_flow.py::test_user_form[pyloop]