Skip to content

Rewrite mfi unittest tests to pytest#42510

Merged
balloob merged 2 commits intohome-assistant:devfrom
adriansuwala:unittest-to-pytest-mfi
Oct 30, 2020
Merged

Rewrite mfi unittest tests to pytest#42510
balloob merged 2 commits intohome-assistant:devfrom
adriansuwala:unittest-to-pytest-mfi

Conversation

@adriansuwala
Copy link
Copy Markdown
Contributor

Proposed change

Rewrite mfi unittest tests to pytest style functions

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@balloob balloob merged commit 6011756 into home-assistant:dev Oct 30, 2020
@adriansuwala adriansuwala deleted the unittest-to-pytest-mfi branch October 30, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants