Skip to content

Gather all collection listeners and changes at the same time#42497

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:gather_collection_listeners
Oct 29, 2020
Merged

Gather all collection listeners and changes at the same time#42497
balloob merged 1 commit intohome-assistant:devfrom
bdraco:gather_collection_listeners

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Oct 27, 2020

Proposed change

I noticed the zone integration was taking a bit longer to load than
expected when I added more zones.

This builds on the improvements in #34783 to gather all the changes at once.

Before

2020-10-27 23:52:48 INFO (MainThread) [homeassistant.setup] Setup of domain zone took 3.9 seconds
2020-10-27 23:53:18 INFO (MainThread) [homeassistant.setup] Setup of domain zone took 3.8 seconds
2020-10-27 23:53:53 INFO (MainThread) [homeassistant.setup] Setup of domain zone took 4.0 seconds

After

2020-10-27 23:54:48 INFO (MainThread) [homeassistant.setup] Setup of domain zone took 2.8 seconds
2020-10-27 23:55:17 INFO (MainThread) [homeassistant.setup] Setup of domain zone took 2.7 seconds
2020-10-27 23:55:41 INFO (MainThread) [homeassistant.setup] Setup of domain zone took 2.8 seconds

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! It doesn't matter for how long I have been writing code, I keep making the same type of mistakes 😅

@balloob balloob merged commit c8f00a7 into home-assistant:dev Oct 29, 2020
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Oct 29, 2020

Very nice! It doesn't matter for how long I have been writing code, I keep making the same type of mistakes 😅

We all do.

@bdraco bdraco deleted the gather_collection_listeners branch October 29, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants