Skip to content

Add guppy3 memory profile to Profiler integration#42435

Merged
hunterjm merged 4 commits intohome-assistant:devfrom
hunterjm:profile-memory
Oct 29, 2020
Merged

Add guppy3 memory profile to Profiler integration#42435
hunterjm merged 4 commits intohome-assistant:devfrom
hunterjm:profile-memory

Conversation

@hunterjm
Copy link
Copy Markdown
Member

@hunterjm hunterjm commented Oct 26, 2020

Proposed change

Add guppy to the Profiler integration in order to also measure heap memory usage. Resulting file can be opened via the Heapy Profile Browser.

#! /usr/bin/python3
from guppy import hpy
# Open profile browser (requires tkinter)
hpy().pb()

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bdraco, mind taking a look at this pull request as its been labeled with an integration (profiler) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Oct 26, 2020

Nice 👍

Comment thread homeassistant/components/profiler/__init__.py Outdated
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Oct 27, 2020

Reminder to update services.yaml

Comment thread homeassistant/components/profiler/__init__.py Outdated
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hunterjm hunterjm merged commit 2a795c0 into home-assistant:dev Oct 29, 2020
Thomas55555 pushed a commit to Thomas55555/core that referenced this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants