Skip to content

Fix enigma2 off state#42407

Merged
frenck merged 5 commits intohome-assistant:devfrom
reaper7:dev
Nov 9, 2020
Merged

Fix enigma2 off state#42407
frenck merged 5 commits intohome-assistant:devfrom
reaper7:dev

Conversation

@reaper7
Copy link
Copy Markdown
Contributor

@reaper7 reaper7 commented Oct 26, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @reaper7,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @fbradyirl, mind taking a look at this pull request as its been labeled with an integration (enigma2) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title fix for https://github.com/home-assistant/core/issues/42258 Fix enigma2 off state Oct 26, 2020
revert back state property
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @reaper7 👍

@frenck frenck merged commit 8fc8ce8 into home-assistant:dev Nov 9, 2020
@reaper7
Copy link
Copy Markdown
Contributor Author

reaper7 commented Nov 9, 2020

basically the changes are only Yours :D
tnx!

@reaper7
Copy link
Copy Markdown
Contributor Author

reaper7 commented Nov 16, 2020

@frenck - please take back this PR, it is not working properly in the real world.
When SAT is ON then Media Player on lovelace interface changes color as if the device is running but the status is still UNAVAILABLE,
probably self.e2_box.is_offline does not return a valid value :(

or maybe... available should return negation of self.e2_box.is_offline ??
I'll check it out in a moment

@reaper7
Copy link
Copy Markdown
Contributor Author

reaper7 commented Nov 16, 2020

yes...

available must look like this:

    @property
    def available(self):
        """Return True if the device is available."""
        return not self.e2_box.is_offline

@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 16, 2020

Could you please open a PR? Thanks 👍

reaper7 added a commit to reaper7/core that referenced this pull request Nov 16, 2020
Available property should return self.e2_box.is_offlin negation

fixes previous PR: home-assistant#42407
@reaper7
Copy link
Copy Markdown
Contributor Author

reaper7 commented Nov 16, 2020

@frenck - I don't know if I done this PR correctly - he was in a strange place

@reaper7
Copy link
Copy Markdown
Contributor Author

reaper7 commented Nov 16, 2020

done #43292

balloob pushed a commit that referenced this pull request Nov 16, 2020
Available property should return self.e2_box.is_offlin negation

fixes previous PR: #42407
balloob pushed a commit that referenced this pull request Nov 16, 2020
Available property should return self.e2_box.is_offlin negation

fixes previous PR: #42407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enigma2 Media Player does not report power off state

4 participants