Fix enigma2 off state#42407
Conversation
|
Hey there @fbradyirl, mind taking a look at this pull request as its been labeled with an integration ( |
revert back state property
|
basically the changes are only Yours :D |
|
@frenck - please take back this PR, it is not working properly in the real world. or maybe... available should return negation of self.e2_box.is_offline ?? |
|
yes... available must look like this: @property
def available(self):
"""Return True if the device is available."""
return not self.e2_box.is_offline |
|
Could you please open a PR? Thanks 👍 |
Available property should return self.e2_box.is_offlin negation fixes previous PR: home-assistant#42407
|
@frenck - I don't know if I done this PR correctly - he was in a strange place |
|
done #43292 |
Available property should return self.e2_box.is_offlin negation fixes previous PR: #42407
Available property should return self.e2_box.is_offlin negation fixes previous PR: #42407
Breaking change
Proposed change
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: