Skip to content

Update "issur_melacha_in_effect" via time tracking#42328

Closed
amitfin wants to merge 35 commits into
home-assistant:devfrom
amitfin:jewish-binary-sensor-time-tracking
Closed

Update "issur_melacha_in_effect" via time tracking#42328
amitfin wants to merge 35 commits into
home-assistant:devfrom
amitfin:jewish-binary-sensor-time-tracking

Conversation

@amitfin
Copy link
Copy Markdown
Contributor

@amitfin amitfin commented Oct 25, 2020

Breaking change

Proposed change

binary_sensor.jewish_calendar_issur_melacha_in_effect used the regular polling mode.
It means that it gets updated within the polling window, and is less precise.
With this change, the binary sensor gets updated on the exact time it should.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
N/A

Additional information

The binary sensor didn't update on the exact time it was supposed to. Fixed that.

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@yuvalabou
Copy link
Copy Markdown
Contributor

Great work!

Copy link
Copy Markdown
Contributor

@tsvi tsvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@amitfin
Copy link
Copy Markdown
Contributor Author

amitfin commented Oct 26, 2020

  1. 2 unrelated branches were mistakenly merged, so I manually deleted all unrelated files from the other branch. (Sorry about the mess).
  2. The version of hdate was bumped to 0.9.12 to include the following fix which is required by the this PR: py-libhdate/py-libhdate@bcc0cd3

@amitfin amitfin mentioned this pull request Oct 26, 2020
21 tasks
@amitfin
Copy link
Copy Markdown
Contributor Author

amitfin commented Oct 27, 2020

Closing this PR and moving the changes to a clean branch with this PR: #42485

@amitfin amitfin closed this Oct 27, 2020
@amitfin amitfin deleted the jewish-binary-sensor-time-tracking branch October 28, 2020 18:34
Thomas55555 pushed a commit to Thomas55555/core that referenced this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants