Update "issur_melacha_in_effect" via time tracking#42328
Closed
amitfin wants to merge 35 commits into
Closed
Conversation
Contributor
|
Great work! |
4 tasks
Contributor
Author
|
…om/amitfin/core into jewish-binary-sensor-time-tracking
…om/amitfin/core into jewish-binary-sensor-time-tracking
Contributor
Author
|
Closing this PR and moving the changes to a clean branch with this PR: #42485 |
21 tasks
Thomas55555
pushed a commit
to Thomas55555/core
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
binary_sensor.jewish_calendar_issur_melacha_in_effect used the regular polling mode.
It means that it gets updated within the polling window, and is less precise.
With this change, the binary sensor gets updated on the exact time it should.
Type of change
Example entry for
configuration.yaml:Additional information
The binary sensor didn't update on the exact time it was supposed to. Fixed that.
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: