Skip to content

Add support for homekit garage obstruction sensors#42243

Merged
bdraco merged 1 commit intohome-assistant:devfrom
bdraco:support_obstruction_sensors
Oct 23, 2020
Merged

Add support for homekit garage obstruction sensors#42243
bdraco merged 1 commit intohome-assistant:devfrom
bdraco:support_obstruction_sensors

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Oct 22, 2020

Proposed change

Add support for homekit garage obstruction sensors

Also allows pass-through from homekit_controller

Requested here : https://community.home-assistant.io/t/homekit-garage-door-status-obstruction-detected/238010

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Jc2k, mind taking a look at this pull request as its been labeled with an integration (homekit_controller) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@Jc2k Jc2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(From a homekit_controller pov, long term I would probably want to break out that attribute as a binary sensor so people can use the new device orientated integrations UI to e.g. send an alarm when there is an obstruction. But that's a long way out so it's probably best to support the existing approach for now).

@bdraco bdraco merged commit 4bf9ce6 into home-assistant:dev Oct 23, 2020
@bdraco bdraco deleted the support_obstruction_sensors branch October 23, 2020 17:18
rajlaud pushed a commit to rajlaud/home-assistant that referenced this pull request Oct 28, 2020
Thomas55555 pushed a commit to Thomas55555/core that referenced this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants