Suppress domain and all listeners during template rate limit#42005
Merged
balloob merged 1 commit intohome-assistant:devfrom Oct 19, 2020
Merged
Suppress domain and all listeners during template rate limit#42005balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
Once we hit the rate limit, turn off the listeners as they are a firehose that we want to ignore. Its much more efficient to not get the callbacks then reject tens of thousands of them.
97691a9 to
fc54625
Compare
balloob
approved these changes
Oct 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had optimized to return as soon as possible when a rate limit
is in effect in #41741, but its better to kill the listeners for
the duration of the rate limit instead of checking it every time.
Proposed change
Suppress domain and all listeners during template rate limit
Once we hit the rate limit, turn off the listeners as they
are a firehose that we want to ignore. Its much more
efficient to not get the callbacks than reject tens
of thousands of them.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: