Skip to content

Suppress domain and all listeners during template rate limit#42005

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:shut_firehouse_on_ratelimit
Oct 19, 2020
Merged

Suppress domain and all listeners during template rate limit#42005
balloob merged 1 commit intohome-assistant:devfrom
bdraco:shut_firehouse_on_ratelimit

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Oct 17, 2020

I had optimized to return as soon as possible when a rate limit
is in effect in #41741, but its better to kill the listeners for
the duration of the rate limit instead of checking it every time.

Proposed change

Suppress domain and all listeners during template rate limit

Once we hit the rate limit, turn off the listeners as they
are a firehose that we want to ignore. Its much more
efficient to not get the callbacks than reject tens
of thousands of them.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Once we hit the rate limit, turn off the listeners as they
are a firehose that we want to ignore. Its much more
efficient to not get the callbacks then reject tens
of thousands of them.
@balloob balloob merged commit 3a9b239 into home-assistant:dev Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants