Skip to content

Remove YAML config for directv#41961

Merged
balloob merged 8 commits intodevfrom
ctalkington-directv-yaml
Oct 29, 2020
Merged

Remove YAML config for directv#41961
balloob merged 8 commits intodevfrom
ctalkington-directv-yaml

Conversation

@ctalkington
Copy link
Copy Markdown
Contributor

@ctalkington ctalkington commented Oct 16, 2020

Breaking change

DirecTV has fully transitioned to configuration via UI. YAML configuration is no longer supported after being automatically imported for several releases

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@ctalkington ctalkington marked this pull request as ready for review October 16, 2020 18:24
@ctalkington ctalkington requested a review from bdraco October 29, 2020 01:11
@balloob balloob changed the title Deprecate YAML config for directv Remove YAML config for directv Oct 29, 2020
@balloob balloob merged commit 0ba1298 into dev Oct 29, 2020
@balloob balloob deleted the ctalkington-directv-yaml branch October 29, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants