Skip to content

Shelly: fix for RGB devices #41841

Merged
balloob merged 1 commit intohome-assistant:devfrom
chemelli74:chemelli74-lights
Oct 14, 2020
Merged

Shelly: fix for RGB devices #41841
balloob merged 1 commit intohome-assistant:devfrom
chemelli74:chemelli74-lights

Conversation

@chemelli74
Copy link
Copy Markdown
Contributor

Proposed change

Current code handle only "relays" and "emeters", but RGB devices has a "lights" block type.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @balloob, @bieniu, mind taking a look at this pull request as its been labeled with an integration (shelly) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob added this to the 0.116.3 milestone Oct 14, 2020
@balloob balloob merged commit 70eebc7 into home-assistant:dev Oct 14, 2020
balloob pushed a commit that referenced this pull request Oct 15, 2020
@balloob balloob mentioned this pull request Oct 15, 2020
@chemelli74 chemelli74 deleted the chemelli74-lights branch October 15, 2020 15:11
weissm pushed a commit to weissm/core that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shelly RGBW2 light entities no longer available after 0.116 upgrade

3 participants