Skip to content

Fix issues with metric conversion and single pump type for filter pumps in Omnilogic integration#41777

Merged
springstan merged 1 commit intohome-assistant:devfrom
djtimca:omnilogic-sensorfix
Oct 13, 2020
Merged

Fix issues with metric conversion and single pump type for filter pumps in Omnilogic integration#41777
springstan merged 1 commit intohome-assistant:devfrom
djtimca:omnilogic-sensorfix

Conversation

@djtimca
Copy link
Copy Markdown
Contributor

@djtimca djtimca commented Oct 13, 2020

Proposed change

Fixes additional issue with metric conversion for salt-units for Hayward users with their controller set to "Metric".
Fixes issue with SINGLE Speed filter pump types. Should NOT create a sensor for these pump types (will be addressed in Switches platform when released).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@djtimca djtimca changed the title Fix additional issue with metric conversion. Fix SINGLE pump type for Filter Pumps. Closes issue 41687 Omnilogic Integration - Fix additional issue with metric conversion. Fix SINGLE pump type for Filter Pumps. Closes issue 41687 Oct 13, 2020
@probot-home-assistant
Copy link
Copy Markdown

Hey there @Oliver84, @gentoosu, mind taking a look at this pull request as its been labeled with an integration (omnilogic) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@springstan springstan changed the title Omnilogic Integration - Fix additional issue with metric conversion. Fix SINGLE pump type for Filter Pumps. Closes issue 41687 Fix issues with metric conversion and single pump type for filter pumps in Omnilogic integration Oct 13, 2020
Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 @djtimca should we tag this for 0.116.3?

@djtimca
Copy link
Copy Markdown
Contributor Author

djtimca commented Oct 13, 2020

@springstan that would be great as it clears an open issue.

@springstan springstan added this to the 0.116.3 milestone Oct 13, 2020
@springstan springstan merged commit 5069fc4 into home-assistant:dev Oct 13, 2020
balloob pushed a commit that referenced this pull request Oct 15, 2020
@balloob balloob mentioned this pull request Oct 15, 2020
weissm pushed a commit to weissm/core that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hayward Omnilogic not handling SINGLE pump type

5 participants