Fix issues with metric conversion and single pump type for filter pumps in Omnilogic integration#41777
Merged
springstan merged 1 commit intohome-assistant:devfrom Oct 13, 2020
Merged
Conversation
… Filters. Closes issue 41687
Oliver84
approved these changes
Oct 13, 2020
springstan
approved these changes
Oct 13, 2020
Member
springstan
left a comment
There was a problem hiding this comment.
Looks good 👍 @djtimca should we tag this for 0.116.3?
Contributor
Author
|
@springstan that would be great as it clears an open issue. |
balloob
pushed a commit
that referenced
this pull request
Oct 15, 2020
…ps in Omnilogic integration (#41777)
Merged
weissm
pushed a commit
to weissm/core
that referenced
this pull request
Oct 16, 2020
…ps in Omnilogic integration (home-assistant#41777)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes additional issue with metric conversion for salt-units for Hayward users with their controller set to "Metric".
Fixes issue with SINGLE Speed filter pump types. Should NOT create a sensor for these pump types (will be addressed in Switches platform when released).
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: