Skip to content

Offload dockermachines into core#41756

Merged
pvizeli merged 1 commit intodevfrom
docker-machine
Oct 13, 2020
Merged

Offload dockermachines into core#41756
pvizeli merged 1 commit intodevfrom
docker-machine

Conversation

@pvizeli
Copy link
Copy Markdown
Member

@pvizeli pvizeli commented Oct 13, 2020

Breaking change

Proposed change

We made good experience to use the core docker on core repository and make it easier to have changes without affect point release. It's now time to offload the latest part of this process into core for have the same experience and handling.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@pvizeli
Copy link
Copy Markdown
Member Author

pvizeli commented Oct 13, 2020

I don't affect tests

@MartinHjelmare
Copy link
Copy Markdown
Member

I don't understand the description. What experience and handling are we comparing with? Can we link to that?

@pvizeli pvizeli merged commit 2d08708 into dev Oct 13, 2020
@pvizeli
Copy link
Copy Markdown
Member Author

pvizeli commented Oct 13, 2020

It's only that we pull data from a different repository which don't merge with the dockerfile/build.json on the branch and end up in a disaster. Now all is the same branch and can be updated together.

balloob pushed a commit that referenced this pull request Oct 15, 2020
@balloob balloob mentioned this pull request Oct 15, 2020
weissm pushed a commit to weissm/core that referenced this pull request Oct 16, 2020
@pvizeli pvizeli deleted the docker-machine branch January 4, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants