Skip to content

Ensure all template errors are caught and the websocket api reports them#41719

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:catch_all_template_errors
Oct 12, 2020
Merged

Ensure all template errors are caught and the websocket api reports them#41719
balloob merged 1 commit intohome-assistant:devfrom
bdraco:catch_all_template_errors

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Oct 12, 2020

Supports #41703

Proposed change

Ensure all template errors are caught and the websocket api reports them

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Oct 12, 2020

Should we tag this for 0.116.x as it likely fixes the reports of templates that stop rendering and never resume?

It looks like there was trouble figuring out why the template was failing in #40221

@bdraco bdraco mentioned this pull request Oct 12, 2020
21 tasks
@balloob balloob added this to the 0.116.3 milestone Oct 12, 2020
@balloob balloob merged commit b897ca7 into home-assistant:dev Oct 12, 2020
@balloob balloob mentioned this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants