Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too agressive .gitignore #41677

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Fix too agressive .gitignore #41677

merged 1 commit into from
Oct 12, 2020

Conversation

thomasloven
Copy link
Contributor

@thomasloven thomasloven commented Oct 11, 2020

Proposed change

This was added to ignore a directory added by virtualenv on windows #18918.
But it accidentally also ignored homeassistant/scripts.
(and tests/scripts I think)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@thomasloven thomasloven changed the title Add homeassistant/scripts to git Fix too agressive .gitignore Oct 11, 2020
@balloob
Copy link
Member

balloob commented Oct 12, 2020

Is your OS case insensitive? 🤔

@balloob balloob merged commit 9e6df38 into home-assistant:dev Oct 12, 2020
@thomasloven
Copy link
Contributor Author

My filesystem (APFS) is.

weissm pushed a commit to weissm/core that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants