Skip to content

Cap AVC profile level at 4.1 in stream master playlist #41592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hunterjm merged 2 commits into from
Oct 15, 2020
Merged

Cap AVC profile level at 4.1 in stream master playlist #41592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87612cd
Cap AVC profile level at 4.1
uvjustin Oct 10, 2020
4ae6291
Use smaller multiplier in bandwidth calculation
uvjustin Oct 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion homeassistant/components/stream/fmp4utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ def get_codec_string(segment: io.BytesIO) -> str:
):
profile = stsd_box[111:112].hex()
compatibility = stsd_box[112:113].hex()
level = stsd_box[113:114].hex()
# Cap level at 4.1 for compatibility with some Google Cast devices
level = hex(min(stsd_box[113], 41))[2:]
codec += "." + profile + compatibility + level

# Handle H265
Expand Down
5 changes: 3 additions & 2 deletions homeassistant/components/stream/hls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,11 @@ class HlsMasterPlaylistView(StreamView):
def render(track):
"""Render M3U8 file."""
# Need to calculate max bandwidth as input_container.bit_rate doesn't seem to work
# Calculate file size / duration and use a multiplier to account for variation
# Calculate file size / duration and use a small multiplier to account for variation
# hls spec already allows for 25% variation
segment = track.get_segment(track.segments[-1])
bandwidth = round(
segment.segment.seek(0, io.SEEK_END) * 8 / segment.duration * 3
segment.segment.seek(0, io.SEEK_END) * 8 / segment.duration * 1.2
)
codecs = get_codec_string(segment.segment)
lines = [
Expand Down