Add support for reordering Shopping List Items via Drag and Drop#41585
Merged
bramkragten merged 11 commits intohome-assistant:devfrom Jan 5, 2021
Merged
Conversation
probot-home-assistant
bot
added
core
has-tests
integration: shopping_list
Hacktoberfest
labels
8 tasks
springstan
changed the title
bdraco
requested changes
Oct 19, 2020
| ) | ||
| new_items.append(all_items_mapping[key]) | ||
| self.items = new_items | ||
| self.hass.async_add_job(self.save) |
Member
There was a problem hiding this comment.
Please use async_add_executor_job
balloob
reviewed
Oct 22, 2020
balloob
reviewed
Oct 22, 2020
| ) | ||
| except vol.Invalid as err: | ||
| connection.send_message( | ||
| websocket_api.error_message(msg_id, "bad_request", f"{err}") |
Member
There was a problem hiding this comment.
Use the websocket_api error ERR_INVALID_FORMAT
balloob
reviewed
Oct 23, 2020
balloob
reviewed
Oct 23, 2020
balloob
reviewed
Oct 23, 2020
| ) | ||
| ) | ||
| except vol.Invalid as err: | ||
| connection.send_message( |
Contributor
Author
There was a problem hiding this comment.
Fixed this and the above 2 issues.
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
balloob
approved these changes
Oct 26, 2020
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
Looks good. Can be merged once frontend is 👍
Contributor
Author
Contributor
|
I'll review again and merge |
Contributor
Author
|
Wanted to leave a comment that if there are issues in the future, please remind me, I'd be happy to help. |
Member
|
Thanks @ShaneQi! That is really appreciated. Would you want to add yourself as a code owner for this integration? |
Contributor
Author
Sure, it's an honor. |
Thomas55555
pushed a commit
to Thomas55555/core
that referenced
this pull request
Feb 24, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adding reordering shopping list items web socket to support drag and drop in shopping list card.
The drag and drop front end pr: home-assistant/frontend#7296
Type of change
Example entry for
configuration.yaml:N/A
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: