Skip to content

Fix Plugwise hvac action and mode#41550

Merged
MartinHjelmare merged 5 commits intohome-assistant:devfrom
plugwise:plugwise-smallfixes
Oct 15, 2020
Merged

Fix Plugwise hvac action and mode#41550
MartinHjelmare merged 5 commits intohome-assistant:devfrom
plugwise:plugwise-smallfixes

Conversation

@CoMPaTech
Copy link
Copy Markdown
Member

@CoMPaTech CoMPaTech commented Oct 9, 2020

Proposed change

Small fixes from testers feedback applied including climate handling and state. With autumn and winter seasons coming climate systems are started again as such we incorporated forthcoming codefixes :)

Version bump changes for module are accordingly and in the changelog of our module.

https://github.com/plugwise/Plugwise-Smile/releases/tag/1.6.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bouwew, mind taking a look at this pull request as its been labeled with an integration (plugwise) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@CoMPaTech CoMPaTech marked this pull request as ready for review October 9, 2020 16:32
Copy link
Copy Markdown
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link
Copy Markdown
Contributor

@Bre77 Bre77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MartinHjelmare MartinHjelmare changed the title Small fixes for Plugwise integration Fix Plugwise hvac action and mode Oct 15, 2020
@MartinHjelmare MartinHjelmare merged commit 368bc0c into home-assistant:dev Oct 15, 2020
@CoMPaTech CoMPaTech deleted the plugwise-smallfixes branch October 15, 2020 18:23
weissm pushed a commit to weissm/core that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants