Introduce conversion to mmol/L in Nightscout

[boc-the-git]

Breaking change

Proposed change

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[homeassistant]

Hi @boc-the-git,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[probot-home-assistant]

Hey there @marciogranzotto, mind taking a look at this pull request as its been labeled with an integration (nightscout) you are listed as a codeowner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[boc-the-git]

My first Hass PR, so I need to spend a bit more time understanding all the things being asked of me, hence having this as draft at the moment. The code is working well for me on my test system.

[marciogranzotto]

I left some comments on things I think you need to change, but also:

• Add tests for both units of measure in tests/components/nightscout
• It would be nice to extract the mg/dL to mmol/L to a function and add unit tests for that, so we can make sure that the conversion is correct
• I think we should move the unit of measure to the Options flow, rather than the Config flow. You can check the details on https://developers.home-assistant.io/docs/config_entries_options_flow_handler/
• Make sure to run all tests and check for coverage on your machine before committing:

pytest --cov-report term-missing --cov=homeassistant.components.nightscout tests/components/nightscout/

[boc-the-git]

Thanks @marciogranzotto, I'll look into this in more detail in the coming days. The most complicated bit for me is likely to be writing the tests, as I haven't looked into that area before :)

[docx1]

@marciogranzotto can you please take a minute of your time and see what's the status of this?
I believe that I speak in the name of the whole Europe, which is trying to use mmol/l units that we badly need this feature.
Thank you

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.