Skip to content

Use common strings in Arcam fmj config flow #41350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elupus merged 1 commit into from
Oct 6, 2020
Merged

Use common strings in Arcam fmj config flow #41350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/arcam_fmj/config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ async def _async_check_and_create(self, host, port):
try:
await client.start()
except ConnectionFailed:
return self.async_abort(reason="unable_to_connect")
return self.async_abort(reason="cannot_connect")
finally:
await client.stop()

Expand Down
4 changes: 2 additions & 2 deletions homeassistant/components/arcam_fmj/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"config": {
"abort": {
"already_configured": "Device was already setup.",
"already_configured": "[%key:common::config_flow::abort::already_configured_device%]",
"already_in_progress": "[%key:common::config_flow::abort::already_in_progress%]",
"unable_to_connect": "Unable to connect to device."
"cannot_connect": "[%key:common::config_flow::error::cannot_connect%]"
},
"error": {},
"flow_title": "Arcam FMJ on {host}",
Expand Down
2 changes: 1 addition & 1 deletion tests/components/arcam_fmj/test_config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ async def test_ssdp_unable_to_connect(hass, dummy_client):

result = await hass.config_entries.flow.async_configure(result["flow_id"], {})
assert result["type"] == data_entry_flow.RESULT_TYPE_ABORT
assert result["reason"] == "unable_to_connect"
assert result["reason"] == "cannot_connect"


async def test_ssdp_update(hass):
Expand Down