Skip to content

Fix TTS ID3 Tag capability check#41343

Merged
frenck merged 1 commit intodevfrom
frenck-2020-0878
Oct 6, 2020
Merged

Fix TTS ID3 Tag capability check#41343
frenck merged 1 commit intodevfrom
frenck-2020-0878

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Oct 6, 2020

Proposed change

In #41191 a change was made to prevent ID3 tags where set on non-ID3 files.
However, new ID3 capable files (e.g., MP3, WAV), don't have to have a ID3 tag at all.

This PR changes the behavior by checking if the file is ID3 capable, instead of the tag contents.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck frenck merged commit 4d12fcc into dev Oct 6, 2020
@frenck frenck deleted the frenck-2020-0878 branch October 6, 2020 15:49
balloob pushed a commit that referenced this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants