Skip to content

Bump hatasmota to 0.0.10, minor refactor of discovery#41331

Merged
emontnemery merged 3 commits intohome-assistant:devfrom
emontnemery:tasmota_bump_hatasmota
Oct 6, 2020
Merged

Bump hatasmota to 0.0.10, minor refactor of discovery#41331
emontnemery merged 3 commits intohome-assistant:devfrom
emontnemery:tasmota_bump_hatasmota

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Oct 6, 2020

Proposed change

Bump hatasmota to 0.0.10, and adjust code accordingly.
Minor refactoring of discovery code.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Comment thread homeassistant/components/tasmota/discovery.py
Comment thread homeassistant/components/tasmota/discovery.py
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emontnemery emontnemery merged commit 42fb0e9 into home-assistant:dev Oct 6, 2020
@emontnemery emontnemery deleted the tasmota_bump_hatasmota branch October 14, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants