Use reference strings in upnp#41327
Use reference strings in upnp#41327springstan merged 4 commits intohome-assistant:devfrom SNoof85:patch-15
Conversation
probot-home-assistant
Bot
added
Hacktoberfest
code-quality
integration: upnp
small-pr
|
Hey there @StevenLooman, mind taking a look at this pull request as its been labeled with an integration ( |
| "abort": { | ||
| "already_configured": "UPnP/IGD is already configured", | ||
| "already_configured": "[%key:common::config_flow::abort::already_configured_service%]", | ||
| "no_devices_discovered": "No UPnP/IGDs discovered", |
There was a problem hiding this comment.
Does this need a reference applied too?
There was a problem hiding this comment.
Yes we can ;)
Edit : but once again no_devices_found ? It's not same error message and i can't find a corresponding common string for no discovered devices.
But basically it is quite the same error message we could remove no_devices_discoveredand use no_devices_foundin config flow for both cases.
There was a problem hiding this comment.
I think using no_devices_found in both cases makes sense.
There was a problem hiding this comment.
let's go for it then
Co-authored-by: scheric <38077357+scheric@users.noreply.github.com>
5 participants
Breaking change
Proposed change
Use reference strings in upnp
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: