Skip to content

Use dict syntax#41325

Merged
MartinHjelmare merged 1 commit intodevfrom
dict-literal
Oct 6, 2020
Merged

Use dict syntax#41325
MartinHjelmare merged 1 commit intodevfrom
dict-literal

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Oct 6, 2020

Breaking change

Proposed change

Use codemod by @foosel that rewrites calls to the dictionary constructor with dictionary define syntax.

Source codemod https://github.com/OctoPrint/codemods/blob/main/dict_to_literal.py

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare merged commit 4d5948b into dev Oct 6, 2020
@delete-merged-branch delete-merged-branch Bot deleted the dict-literal branch October 6, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants