Skip to content

Add ZHA Analog Input cluster for XBee#41311

Merged
Adminiuga merged 2 commits intohome-assistant:devfrom
Shulyaka:xbee_analog_input
Oct 6, 2020
Merged

Add ZHA Analog Input cluster for XBee#41311
Adminiuga merged 2 commits intohome-assistant:devfrom
Shulyaka:xbee_analog_input

Conversation

@Shulyaka
Copy link
Copy Markdown
Contributor

@Shulyaka Shulyaka commented Oct 6, 2020

Breaking change

No

Proposed change

Add Analog Input cluster for XBee devices (#36696 regression).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
zha:

Additional information

  • This PR fixes or closes issue: fixes XBee Analog Inputs #41286
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Shulyaka Shulyaka changed the title Add ZHA XBee Analog Input cluster Add ZHA Analog Input cluster for XBee Oct 6, 2020
@Shulyaka
Copy link
Copy Markdown
Contributor Author

Shulyaka commented Oct 6, 2020

Should we change manufacturer to Digi by the way?

@Adminiuga
Copy link
Copy Markdown
Contributor

up to you. I'm happy with either. This is coming from the quirk itself (model and manuf), isn't it? it is not saved in zigbee.db as attribute cache?

@Shulyaka
Copy link
Copy Markdown
Contributor Author

Shulyaka commented Oct 6, 2020

This is coming from the quirk itself (model and manuf), isn't it?

Yes. Here is the PR for the quircks: zigpy/zha-device-handlers#513

it is not saved in zigbee.db as attribute cache?

Not sure what is saved, but in my tests, changing the manufacturer in the quirk and restarting HA immidiately affects the presence of the analog sensor, no need to remove or pair the device again.

I'm happy with either

Let me change it to Digi then. xbee_xbee3_f9239841_analog_input looks too repetitive to me.

@Adminiuga Adminiuga merged commit 9b947e0 into home-assistant:dev Oct 6, 2020
@Shulyaka Shulyaka deleted the xbee_analog_input branch October 7, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XBee Analog Inputs

4 participants