Skip to content

Handle somfy error 404 during setup #41298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Oct 6, 2020
Merged

Handle somfy error 404 during setup #41298

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8cf4cb
Handle error 404 during setup
tetienne Oct 5, 2020
0a0ccef
Set devices to empty during the setup
tetienne Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions homeassistant/components/somfy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,3 +179,4 @@ async def update_all_devices(hass):
data[DEVICES] = await hass.async_add_executor_job(data[API].get_devices)
except HTTPError as err:
_LOGGER.warning("Cannot update devices: %s", err.response.status_code)
data[DEVICES] = []

@tetienne tetienne Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow to avoid the error KeyError: 'devices' during the setup.

@balloob balloob Oct 6, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also means that if fetching ever becomes an error, it will also override all devices.

Wouldn't it be better if we initialize this constant with an empty list and let errors not mess with it ?

@tetienne tetienne Oct 6, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I think about it also and hesitate. I will make the modification.