Rewrite recorder unittest tests to pytest style test function#41264
Conversation
|
Oh no I broke it, I am so sorry. |
|
I removed my "improvement" and your fixes. I couldn't get it working locally either 🤔 |
|
I got it working now. Tests on another component were dependent on the common functions to be synchronous. |
|
If you want we can chop off the last 5 commits, have the tests pas (as they before my change) and call it a day. |
|
I would like to investigate the issue but I'm not managing to make it fail locally. Any ideas? |
|
I was able to reproduce it with Python 3.8 locally. |
|
Ok this is a shame. I will remove the last 5 commits. I'm running |
|
We can always try to solve it in a future PR. Asyncio is offered via various test plugins, last time I checked there was no native asyncio support. That might interfere when we start getting async and sync fixtures mixed up with async tests. |
Proposed change
Rewrite unit tests in the following files to be pytest functions:
All other tests on the recorder module are already pytest functions.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: