Skip to content

Bump apprise version to avoid sync in async issues#41253

Merged
balloob merged 1 commit intohome-assistant:devfrom
raman325:apprise_bump
Oct 5, 2020
Merged

Bump apprise version to avoid sync in async issues#41253
balloob merged 1 commit intohome-assistant:devfrom
raman325:apprise_bump

Conversation

@raman325
Copy link
Contributor

@raman325 raman325 commented Oct 5, 2020

Proposed change

The current version of apprise does I/O in the event loop. The version bump prevents that from happening. I also removed the instantiation call that tried to force apprise to be sync (it didn't do anything).

Release notes: https://github.com/caronc/apprise/releases/tag/v0.8.9

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@caronc
Copy link
Contributor

caronc commented Oct 5, 2020

Great work man! 👍

@raman325 raman325 added this to the 0.116.0 milestone Oct 5, 2020
@balloob balloob merged commit baef8b0 into home-assistant:dev Oct 5, 2020
@raman325 raman325 deleted the apprise_bump branch October 5, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants