Skip to content

Update axis to use common strings#41164

Merged
MartinHjelmare merged 3 commits intohome-assistant:devfrom
davet2001:axis_use_common_strings
Oct 6, 2020
Merged

Update axis to use common strings#41164
MartinHjelmare merged 3 commits intohome-assistant:devfrom
davet2001:axis_use_common_strings

Conversation

@davet2001
Copy link
Copy Markdown
Contributor

Proposed change

Update axis to use common strings

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Kane610, mind taking a look at this pull request as its been labeled with an integration (axis) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Comment thread homeassistant/components/axis/strings.json Outdated
@davet2001 davet2001 force-pushed the axis_use_common_strings branch from e805a72 to 8e5c325 Compare October 4, 2020 23:04
Comment thread homeassistant/components/axis/strings.json Outdated
@MartinHjelmare MartinHjelmare merged commit 33e69fe into home-assistant:dev Oct 6, 2020
@davet2001 davet2001 deleted the axis_use_common_strings branch December 2, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants