Skip to content

Verify template sensors that reference other template sensors can reload#41031

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:verify_template_reload_recovers
Oct 2, 2020
Merged

Verify template sensors that reference other template sensors can reload#41031
balloob merged 1 commit intohome-assistant:devfrom
bdraco:verify_template_reload_recovers

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Oct 1, 2020

Proposed change

The issue in #40611 has already been fixed. This test is verify that we don't regress it in the future.

Verified the test fails on 0.115.6, but passes on 0.116.0b1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @PhracturedBlue, @tetienne, mind taking a look at this pull request as its been labeled with an integration (template) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob merged commit b1ba1a7 into home-assistant:dev Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Reload Template Entities' breaks any template entities that refer to other template entities.

3 participants