Skip to content

Use references in airvisual strings.json#41005

Merged
bachya merged 1 commit intohome-assistant:devfrom
daveychu:use_references_airvisual
Oct 1, 2020
Merged

Use references in airvisual strings.json#41005
bachya merged 1 commit intohome-assistant:devfrom
daveychu:use_references_airvisual

Conversation

@daveychu
Copy link
Copy Markdown
Contributor

@daveychu daveychu commented Oct 1, 2020

Proposed change

Use references in airvisual strings.json

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bachya, mind taking a look at this pull request as its been labeled with an integration (airvisual) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@daveychu daveychu force-pushed the use_references_airvisual branch from e3aee09 to 8003770 Compare October 1, 2020 19:21
Copy link
Copy Markdown
Contributor

@bachya bachya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bachya bachya merged commit 4b225a8 into home-assistant:dev Oct 1, 2020
@daveychu daveychu deleted the use_references_airvisual branch October 1, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants